Issue Description
Type: bug report or feature request
Describe what happened (or what feature you want)
现象：
使用1.8.2版本的sentinel-dubbo-adapter模块，非业务异常（Sentinel因为熔断或者限流的异常）被消费者SentinelDubboConsumerFilter记录成为了一次业务异常，逻辑错误。
原因：
在sentinel-dubbo-adapter模块利用了Dubbo的Filter机制，包裹了一层。先看SentinelDubboProviderFilter的逻辑，我们设想提供者端触发了限流，则会抛出BlockException，但是返回给消费者的异常并不是BlockException，而是包裹成为了SentinelRpcException。
而在SentinelDubboConsumerFilter端，result.hasException() 则会为true，触发Tracer.traceEntry() 逻辑，这里面的shouldTrace()方法只判断了排除BlockException，而SentinelRpcException未被排除，即会被记录为一次业务异常。会造成consumer端熔断判断的失误。
Describe what you expected to happen
在Tracer.traceEntry()逻辑中，也要去掉SentinelRpcException，遇到这个异常 则不记录，和BlockException同等对待。
解决方案：
1.可自定义一个init接口，Sentinel启动初始化时调用Tracer.setExceptionsToIgnore() 把SentinelRpcException加进去
2.因为DubboFilter类在dubbo启动refer或者export时会被加载，可在filter的静态块调用Tracer.setExceptionsToIgnore()把SentinelRpcException加进去
How to reproduce it (as minimally and precisely as possible)
- 设置2个dubbo服务，A，B。A调用B。
- 给A设置异常数熔断规则，给B设置限流规则。保证业务无异常。
- 让B触发限流
- A会被熔断
Tell us your environment
Win10 ，Dubbo2.6.5，Sentinel1.8.2，Nacos2.0.3
Anything else we need to know?
why wrap this exception？
4条答案
按热度按时间lx0bsm1f1#
Hi, this should not be wrapped with
SentinelRpcExceptionanymore. Would you like to contribute a PR to fix it?m1m5dgzv2#
Yes, I will fix it later and submit a PR.
uqxowvwt3#
Hi @sczyh30 ,I think we may still need to wrap the
BlockException,becauseBlockExceptiondoesn't implement theJava.io.Serializable,and it isn't aRuntimeException. It will cause a Dubbo serialization exception or wrapped with theUndeclaredThrowableExceptionif we use the AOP. Can we modify the methodcom.alibaba.csp.sentinel.Tracer#shouldTrace, excluding theSentinelRpcExceptionor set theignoreClasses? Or any other suggestions? I'm trying to find the best solution to fix it .de90aj5v4#
The
BlockExceptionhas been converted to aRuntimeExceptionbytoRuntimeException().