Sentinel It is supposed to log with warn-level instead of info-level

70gysomp 于 2022-10-19 发布在其他

关注(0)|答案(2)|浏览(172)

Issue Description

Describe what happened (or what feature you want)

if (flushInterval <= 0) {
    RecordLog.info("[FlowRuleManager] The MetricTimerListener isn't started. If you want to start it, "
            + "please change the value(current: {}) of config({}) more than 0 to start it.", flushInterval,
        SentinelConfig.METRIC_FLUSH_INTERVAL);
    return;
}

it is logging with info-level.

Describe what you expected to happen

There should log with warn-level because if flushInterval <= 0 there should be a warning.

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?

sentinel

来源：https://github.com/alibaba/Sentinel/issues/2686

2条答案

按热度按时间

cigdeys31#

I think info level is better here. because the interval value is set by user self. he know what mean about this action. it's just a info mean this parameter work.

赞(0）回复(0）举报 2022-10-19

hc2pp10m2#

I think info level is better here. because the interval value is set by user self. he know what mean about this action. it's just a info mean this parameter work.

Maybe someone is not aware of being configuring the interval smaller than 0 himself.By this,it is more obvious for him when the warning but not info shows.And it is abnormal to configure interval smaller than 0 because this will cause the SCHEDULER not to work.

赞(0）回复(0）举报 2022-10-19

我来回答