powershell IF语句发送多个结果

nfzehxib 于 2023-03-30 发布在 Shell

关注(0)|答案(1)|浏览(113)

我有一个PowerShell脚本，循环通过AD和发送电子邮件给密码在14，7，和3天到期的用户。一些个人，它的行为正常，其他时候，它会发送几封电子邮件给同一个人。

#Set Global Variables
$sender = "email@xyz.com"
$MailSubject = "Domain/VPN/Office 365: Password Expiring Notification!" 
$maxPasswordAge = '90'

#Run the command to get information from Active Directory
$CommandToGetInfoFromAD = Get-ADUser -filter * -properties PasswordLastSet, PasswordExpired, PasswordNeverExpires, EmailAddress, GivenName, mail

#Loop through all users and compare dates.
$CommandToGetInfoFromAD | ForEach {
    $Today = (Get-Date)
    $UserName = $_.GivenName
    $email = $_.mail
    if (!$_.PasswordExpired -and !$_.PasswordNeverExpires) {
        $ExpiryDate = ($_.PasswordLastSet+$maxPasswordAge)
        $ExpiryDateForEmail = $ExpiryDate.ToString("dddd, MMMM dd yyyy a\t hh:mm tt")
        $DaysLeft = ($ExpiryDate-$Today).days

$props = @{
SMTPServer = "relay.xyz"
From = $sender
To = $email
Subject = $MailSubject
}

$body = @"
<p>$UserName,</p>
<p>This is a courtesy reminder that your Domain password is set to expire on $ExpiryDateForEmail.<br>
<br>
#body removed
"@

}

if ($DaysLeft -eq 14) {
    
    Send-MailMessage @props -body $body -BodyAsHtml -verbose
    }

  elseif ($DaysLeft -eq 7) {
  
    Send-MailMessage @props -body $body -BodyAsHtml -verbose
}

  elseif ($DaysLeft -eq 3) {

    Send-MailMessage @props -body $body -BodyAsHtml -Verbose
}
  
}

它应该只发送一次给每个用户每天。它运行作为一个计划任务每天一次。有些日子它工作正常，其他日子/用户它会发送35+电子邮件。

powershell

来源：https://stackoverflow.com/questions/75687723/if-statement-sending-multiple-results

1条答案

按热度按时间

kqlmhetl1#

您的代码可以使用更好的缩进，这样更容易发现可能出错的地方。
另外，我将使用占位符{0}和{1}创建主体模板Here-string，稍后将插入用户GivenName和expirydate。仅在您确定要使用它的地方创建$props飞溅哈希表。
试试看：

# Set Global Variables
$sender         = 'email@xyz.com'
$smtpServer     = 'relay.xyz'
$MailSubject    = 'Domain/VPN/Office 365: Password Expiring Notification!'
$maxPasswordAge = 90  # an integer value, so no quotes here

# use a Here-string for the body with two placeholders
$body = @'
<p>{0},</p>
<p>This is a courtesy reminder that your Domain password is set to expire on {1}.<br>
<br>
#body removed
'@

# Run the command to get information from Active Directory
# property GivenName is automatically returned, same as DistinguishedName, Enabled, Name, ObjectClass, 
# ObjectGUID, SamAccountName, SID, Surname and UserPrincipalName
$users = Get-ADUser -Filter * -properties PasswordLastSet, PasswordExpired, PasswordNeverExpires, EmailAddress

# Loop through all users and compare dates.
$users | ForEach-Object {
    if (!$_.PasswordExpired -and !$_.PasswordNeverExpires) {
        $Today      = (Get-Date)
        $ExpiryDate = $_.PasswordLastSet.AddDays($maxPasswordAge)
        $DaysLeft   = ($ExpiryDate - $Today).Days
        # only send an email if the number of days left is 14, 7 or 3
        if (3,7,14 -contains $DaysLeft) {  
            $props = @{
                SMTPServer = $smtpServer
                From       = $sender
                To         = $_.EmailAddress
                Subject    = $MailSubject
                Body       = $body -f $_.GivenName, $ExpiryDate.ToString("dddd, MMMM dd yyyy a\t hh:mm tt")
                BodyAsHtml = $true
            }
            Send-MailMessage @props -Verbose
        }
    }
}

除了使用用户的mail或EmailAddress属性之外，还可以从users的ProxyAddresses属性中获取主电子邮件地址
首先将ProxyAddresses附加到您要使用Get-ADUser获取的属性列表中，然后在$props中设置To地址，如下所示：

To = ($_.ProxyAddresses | Where-Object { $_ -clike 'SMTP:*' }) -creplace '^SMTP:'  
# all-caps SMTP: is the primary email address

赞(0）回复(0）举报 2023-03-30

我来回答

powershell IF语句发送多个结果

1条答案

相关问题

热门标签

最新问答