因为low_expenses的初始值为零，所以你永远找不到任何一年的费用更低，除非费用是负的。你应该初始化你的low_expenses为最大可能的整数，如下所示：

low_expenses{ std::numeric_limits<int>::max() };

如果开销可以为负，那么将high_expenses初始化为最低可能值也会有所帮助：

high_expenses{ std::numeric_limits<int>::min() };

您需要包含<limits>头才能工作。
此外，正如WhozCraig所指出的，这条线

infile >> year >> mall >> cafe >> expenses;

将丢弃一行输入。这是不必要的。您可以将low_...和high_...初始化为第一行的值，但随后可能还必须检查第一个I/O操作是否成功。（如果没有行）

初始化你的最高和最低的内容后，初始读取之前，进入循环读取其余部分。
示例：

void price(ifstream &infile)
{
    infile.clear();
    infile.seekg(0);

    int year, mall, cafe, expenses;
    if (infile >> year >> mall >> cafe >> expenses)
    {
        int high_mall{mall}, high_year{year}, high_expenses{expenses};
        int low_mall{mall}, low_year{year}, low_expenses{expenses};

        while (infile >> year >> mall >> cafe >> expenses)
        {
            if (expenses > high_expenses)
            {
                high_expenses = expenses;
                high_year = year;
                high_mall = mall;
            }
            else if (expenses < low_expenses)
            {
                low_expenses = expenses;
                low_year = year;
                low_mall = mall;
            }
        }

        cout << "Highest expenses are " << high_expenses << "at" << high_year << endl;
        cout << "Total mall that year are " << high_mall << endl;

        cout << "Lowest expenses are " << low_expenses << "at" << low_year << endl;
        cout << "Total mall that year are " << low_mall << endl;
    }
}

一个好的做法是使用标准库已经提供的thin。std::minmax_element正是你所需要的。
也可以将stream转换为某些特定数据的迭代器：std::istream_iterator。
这两件事可以组合成下面的代码：

struct Data
{
    int year, mall, cafe, expenses;
};

std::istream& operator>>(std::istream& in, Data& data)
{
    return in >> data.year >> data.mall >> data.cafe >> data.expenses;
}

std::ostream& operator<<(std::ostream& out, const Data& data)
{
    return out << data.year << ", " << data.mall << ", " << data.cafe << ", " << data.expenses;
}

int main()
{
    auto result = std::minmax_element(std::istream_iterator<Data>{std::cin}, {}, 
        [](const auto& a, const auto& b) { return a.expenses < b.expenses; });

    std::cout << *result.first << '\n';
    std::cout << *result.second << '\n';

    return 0;
}

https://godbolt.org/z/EMvjx5Yrq

我试了一下，效果很好

void price (ifstream & infile)
{

   infile.clear();
   infile.seekg(0);

  int year, mall, cafe, expenses;

  int high_mall {} , high_year {}, high_expenses {};

  int low_mall;
  int low_year;
  int low_expenses;

  for (int year {}, mall {}, cafe {}, expenses {};
   nameFile >> year >> mall >> cafe >> expenses; )
{

    if (expenses > high_expenses)
    {
        high_expenses = expenses;
        high_year = year;
        high_mall = mall;
    }
     if (expenses < low_expenses)
    {
        low_expenses = expenses;
        low_year = year;
        low_mall = mall;
    }
}

    cout << "Highest expenses are " << high_expenses << "at" << high_year << endl;
    cout << "Total mall that year are " << high_mall << endl ;
    
    cout << "Lowest expenses are " << low_expenses << "at" << low_year << endl;
    cout << "Total mall that year are " << low_mall << endl ;

}