- I have searched the issues of this repository and believe that this is not a duplicate.
Ⅰ. Issue Description
zk not take into account the situation of push-empty protection
zk客户端实现没有考虑到空推保护的情况
Ⅱ. Describe what happened
If there is an exception, please attach the exception trace:
Just paste your stack trace here!
Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)
- xxx
- xxx
- xxx
Minimal yet complete reproducer code (or URL to code):
Ⅴ. Anything else we need to know?
Ⅵ. Environment:
- JDK version(e.g.
java -version
): - Seata client/server version:
- Database version:
- OS(e.g.
uname -a
): - Others:
3条答案
按热度按时间8qgya5xd1#
我怀疑这是一个bug,作者可能想的是node如果被删了最好把对应的cluster也删掉,避免浪费内存空间.但是else if中又对instaces做了判空处理,防止推空,所以这是一个矛盾的产物.我建议修复方案
如果社区有更好的建议欢迎在这一起讨论
I suspect this is a bug. The author may be thinking that if node is deleted, it is best to delete the corresponding cluster to avoid wasting memory space. But in else if, instaces is judged empty to prevent empty, so this is a contradictory product. I suggest a fix
If the community has better suggestions, welcome to discuss them together.
qmelpv7a2#
我怀疑这是一个bug,作者可能想的是node如果被删了最好把对应的cluster也删掉,避免浪费内存空间.但是else if中又对instaces做了判空处理,防止推空,所以这是一个矛盾的产物.我建议修复方案
如果社区有更好的建议欢迎在这一起讨论
I suspect this is a bug. The author may be thinking that if node is deleted, it is best to delete the corresponding cluster to avoid wasting memory space. But in else if, instaces is judged empty to prevent empty, so this is a contradictory product. I suggest a fix
If the community has better suggestions, welcome to discuss them together.
I agree with this plan. Regarding the original cluster list, I think we can consider not deleting it for the time being, as the actual data volume it occupies is quite small.
icnyk63a3#
我怀疑这是一个bug,作者可能想的是node如果被删了最好把对应的cluster也删掉,避免浪费内存空间.但是else if中又对instaces做了判空处理,防止推空,所以这是一个矛盾的产物.我建议修复方案
如果社区有更好的建议欢迎在这一起讨论
I suspect this is a bug. The author may be thinking that if node is deleted, it is best to delete the corresponding cluster to avoid wasting memory space. But in else if, instaces is judged empty to prevent empty, so this is a contradictory product. I suggest a fix
If the community has better suggestions, welcome to discuss them together.
理解一下,处理逻辑和 #6164 redis 处理的差不多的,移除的时候需要 check 一下 回调集群 如果和 当前正在使用的集群 不一致,才能允许空推移除, 并且需要移除listener, 取消订阅
Understand that the processing logic is similar to that of #6164 redis processing. When removing, you need to check the callback cluster. If it is inconsistent with the cluster currently in use, empty push removal can be allowed. , and need to remove the listener and unsubscribe