ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
/**
* Initialize the component
*/
void initialize() throws IllegalStateException;
/**
* Starts the component.
* @return
*/
Future start() throws IllegalStateException;
/**
* Stops the component.
*/
void stop() throws IllegalStateException;These three methods both exists in ApplicationDeployer , ModuleDeployer and Deployer . Can we delete them from ApplicationDeployer and ModuleDeployer ?
BTW , some methods in ApplicationDeployer and ModuleDeployer are duplicated. Can we pull them up to Deployer ?
If there is no other issue, I will commit a pr to fix them.
3条答案
按热度按时间xdnvmnnf1#
Whether or not to delete the duplicated methods in the ApplicationDeployer and ModuleDeployer interfaces compared to the Deployer interface would depend on the specific design and requirements of your software system.
If the ApplicationDeployer and ModuleDeployer interfaces are intended to extend the Deployer interface and add additional functionality, then the duplicated methods may be necessary in order to ensure that each interface has a consistent set of methods that implementers must provide.
On the other hand, if the duplicated methods are not necessary for the functionality of the ApplicationDeployer and ModuleDeployer interfaces, then they could potentially be removed to simplify the interfaces and reduce code duplication.
yduiuuwa2#
I am talking about ApplicationDeployer and Deployer. It is the code of dubbo. There is no 'my software system'. @imSanko
ppcbkaq53#
BTW , some methods in ApplicationDeployer and ModuleDeployer are duplicated. Can we pull them up to Deployer ?
Sure